Migrate to CoreJvm Compiler#7
Merged
alexander-yevsyukov merged 26 commits intomasterfrom Sep 29, 2025
Merged
Conversation
Also: * Expose `TEMPORARILY_DISABLE_PROTOBUF_VERSION_CHECK` environment variable.
…e-to-compiler # Conflicts: # build.gradle.kts # buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt # buildSrc/src/main/kotlin/io/spine/dependency/local/ToolBase.kt # buildSrc/src/main/kotlin/jvm-module.gradle.kts
... instead of `spine` to avoid the name clash with the Root Gradle Plugin extension.
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the BuildSpeed project to use the CoreJvm Compiler, updating the build configuration and removing unused components to optimize build performance.
- Migrates from McJava/ProtoData-based toolchain to CoreJvm Compiler
- Updates proto validation syntax from legacy options to new
(choice).requiredformat - Removes extensive buildSrc code and config submodule to reduce build overhead
Reviewed Changes
Copilot reviewed 197 out of 207 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
settings.gradle.kts.template |
Updated version catalog to use CoreJvm compiler dependencies |
gradlew and gradlew.bat |
Modified wrapper scripts to use direct JAR execution and disabled Protobuf version check |
gradle.properties |
Updated JVM arguments and added debug option |
buildSrc/ |
Removed extensive unused build configuration code |
config |
Removed config submodule reference |
| Proto files | Updated validation syntax from (is_required) to (choice).required |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/proto/spine/buildtool/speed/managementofprojects/rich_text.proto
Show resolved
Hide resolved
armiol
approved these changes
Sep 29, 2025
... as no longer needed. We take the CoreJvm Compiler version from the version catalog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the BuildSpeed to use CoreJvm Compiler.
Changes in details
settings.gradle.ktsfile was updated to mention new dependencies.buildSrcwas largely cleaned up from non-unsed code so that its build time does not add up to the measurements.configsubmodule was removed as it's not applicable to this bare-bones build project.